-
Notifications
You must be signed in to change notification settings - Fork 5k
VertexAI Initial draft- prompt response logging #46383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VertexAI Initial draft- prompt response logging #46383
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishleenk17 all these changes are expected in the generated docs based on your changes in x-pack/metricbeat/module/gcp/vertexai_logs/_meta/docs.md
and x-pack/metricbeat/module/gcp/vertexai_logs/_meta/fields.yml
. Some notes below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new metricset called vertexai_logs
for the GCP module in Metricbeat to collect Vertex AI prompt-response logs from BigQuery. The metricset enables monitoring and analysis of AI model usage by querying BigQuery tables that contain exported Vertex AI interaction logs.
Key changes include:
- New
vertexai_logs
metricset implementation with BigQuery integration - Configuration support for BigQuery table access and credentials
- Comprehensive test coverage and documentation
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
x-pack/metricbeat/module/gcp/vertexai_logs/vertexai_logs.go |
Core metricset implementation with BigQuery client and data fetching logic |
x-pack/metricbeat/module/gcp/vertexai_logs/data.go |
Data structures and event creation logic for Vertex AI log rows |
x-pack/metricbeat/module/gcp/vertexai_logs/vertexai_logs_test.go |
Comprehensive test suite covering query generation, event creation, and data mapping |
x-pack/metricbeat/module/gcp/vertexai_logs/_meta/fields.yml |
Field definitions for the vertexai_logs metricset |
x-pack/metricbeat/module/gcp/vertexai_logs/_meta/docs.md |
Documentation explaining the metricset functionality and configuration |
x-pack/metricbeat/module/gcp/vertexai_logs/_meta/data.json |
Sample event data for the metricset |
Configuration and reference files | Updates to enable and document the new metricset |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* VertexAI Initial draft- prompt response logging * Add changelog * make update * Add test file * Add documentation * Update docs * Update documentaion and make update * Resolve lint errors * Updated test file * Remove test file * Add test file * update test file * Update x-pack/metricbeat/module/gcp/vertexai_logs/_meta/docs.md Co-authored-by: Copilot <[email protected]> * Update the partiotin logic in BigQuery * Add support of logging time filtering * reshuffle imports in vertexai_logs_test.go * Add string datatype for request id * Address comments * Remove the otel_log field * Update vertexai_logs.go * Update vertexai_logs_test.go * Replace run with read * Linter error * linter fix * LINTER ERROR * rerun make update --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Mykola Kmet <[email protected]> Co-authored-by: Colleen McGinnis <[email protected]> (cherry picked from commit e3c6cce)
Proposed commit message
Add a new metricset to support prompt and response logging for GCP VertexAI Logging by querying the BigQuery Table
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Issue
Screenshots
TODO: