Skip to content

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Sep 4, 2025

Proposed commit message

See title

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

Build the docs, navigate to http://localhost:3000/release-notes/known-issues

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr self-assigned this Sep 4, 2025
@belimawr belimawr added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-9.1 Automated backport to the 9.1 branch labels Sep 4, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 4, 2025
Copy link
Contributor

github-actions bot commented Sep 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@belimawr belimawr added the Team:Docs Label for the Observability docs team label Sep 4, 2025
@belimawr belimawr linked an issue Sep 4, 2025 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Sep 4, 2025

🔍 Preview links for changed docs

@belimawr belimawr changed the title [Filebeat] add known issue entries about Filestream clean_inactive [9.x][Filebeat] add known issue entries about Filestream clean_inactive Sep 4, 2025
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor suggestions below.

The Filestream input does not enforce the restrictions documented for
the `clean_inactive` option, thus allowing configurations that can
lead to data re-ingestion issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue and/or PR we can link to? Something like... For more information, refer to [issue #](issue link).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no.

There is the issue/task: #45601, but I don't believe it is very helpful for users to read it.

The PR (#46373) adding it does not contain much details about the issue, it's more about the fix.


When `clean_inactive: 0` Filestream will clean the state of all files
on start up, effectively re-ingesting all files on restart.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue/PR you can link to here, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same thing as #46392 (comment)

Copy link
Contributor

mergify bot commented Sep 5, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 45601-clean-inactive-known-issues-main upstream/45601-clean-inactive-known-issues-main
git merge upstream/main
git push upstream 45601-clean-inactive-known-issues-main

Copy link
Contributor

mergify bot commented Sep 8, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 45601-clean-inactive-known-issues-main upstream/45601-clean-inactive-known-issues-main
git merge upstream/main
git push upstream 45601-clean-inactive-known-issues-main

lead to data re-ingestion issues.

**Fixed in**: 9.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're backporting to 9.1, I wonder if we should hold off on adding this line or reframe to something like this until the release:

Suggested change
**Fixed in**: 9.2.0
**Fix planned in**: 9.2.0

This is where it might be helpful to link to the PR that fixes it so if the user is in doubt and particularly interested in this issue, they can check the changelog as a source of truth. I'll leave it up to you, and I won't block this PR from being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9.1 Automated backport to the 9.1 branch Team:Docs Label for the Observability docs team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filestream reingests data when clean_inactive is set
3 participants