-
Notifications
You must be signed in to change notification settings - Fork 5k
[9.x][Filebeat] add known issue entries about Filestream clean_inactive #46392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[9.x][Filebeat] add known issue entries about Filestream clean_inactive #46392
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple minor suggestions below.
The Filestream input does not enforce the restrictions documented for | ||
the `clean_inactive` option, thus allowing configurations that can | ||
lead to data re-ingestion issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue and/or PR we can link to? Something like... For more information, refer to [issue #](issue link)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
When `clean_inactive: 0` Filestream will clean the state of all files | ||
on start up, effectively re-ingesting all files on restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue/PR you can link to here, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same thing as #46392 (comment)
Co-authored-by: Colleen McGinnis <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
This pull request is now in conflicts. Could you fix it? 🙏
|
…tive-known-issues-main
…tive-known-issues-main
This pull request is now in conflicts. Could you fix it? 🙏
|
lead to data re-ingestion issues. | ||
|
||
**Fixed in**: 9.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're backporting to 9.1, I wonder if we should hold off on adding this line or reframe to something like this until the release:
**Fixed in**: 9.2.0 | |
**Fix planned in**: 9.2.0 |
This is where it might be helpful to link to the PR that fixes it so if the user is in doubt and particularly interested in this issue, they can check the changelog as a source of truth. I'll leave it up to you, and I won't block this PR from being merged.
Proposed commit message
See title
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
Build the docs, navigate to http://localhost:3000/release-notes/known-issues
Related issues
clean_inactive
is set #45601## Use cases## Screenshots## Logs