-
Notifications
You must be signed in to change notification settings - Fork 29
Sync URL search params with search term #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3f77c8e
to
7e41704
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if these need to be linkable? The popover is a navigation aid. E.g the query can happen on ALL the pages.
We should discuss the full UX of this and whether we want a generic /search page or if we should forward that to the generic site search page?
If we do want them to be linked we need to take care these are not susceptible to SEO poisoning.
We will need to update our parent's robots.txt which might be hard/messy if these q=?
can appear on all the pages.
IIUC, the |
@Mpdreamz what are your thoughts on using the URL fragment. E.g. |
Not a bad idea! Should never conflict with our slugs. |
Changes
Recording
cursorful-video-1756815283303.mp4