Skip to content

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Sep 2, 2025

Changes

  • Sync search term with URL search params to be able to share search results

Recording

cursorful-video-1756815283303.mp4

@reakaleek reakaleek force-pushed the feature/sync-query-string branch from 3f77c8e to 7e41704 Compare September 2, 2025 12:19
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these need to be linkable? The popover is a navigation aid. E.g the query can happen on ALL the pages.

We should discuss the full UX of this and whether we want a generic /search page or if we should forward that to the generic site search page?

If we do want them to be linked we need to take care these are not susceptible to SEO poisoning.

We will need to update our parent's robots.txt which might be hard/messy if these q=? can appear on all the pages.

https://www.elastic.co/robots.txt

@reakaleek
Copy link
Member Author

reakaleek commented Sep 3, 2025

I wonder if these need to be linkable? The popover is a navigation aid. E.g the query can happen on ALL the pages.

We should discuss the full UX of this and whether we want a generic /search page or if we should forward that to the generic site search page?

If we do want them to be linked we need to take care these are not susceptible to SEO poisoning.

We will need to update our parent's robots.txt which might be hard/messy if these q=? can appear on all the pages.

https://www.elastic.co/robots.txt

IIUC, the <link rel="canonical" href="..." /> should avoid this problem. which we already have.

@reakaleek
Copy link
Member Author

@Mpdreamz what are your thoughts on using the URL fragment.

E.g. elastic.co/docs#search:what+is+ilm would open the popover with "what is ilm"

@Mpdreamz
Copy link
Member

Not a bad idea! Should never conflict with our slugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants