Add agent_policy_id and policy_revision_idx to checkin requests #9931
+177
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
enhancement
|
Adding integration/e2e tests requires the fleet-server to be implemented first: elastic/fleet-server#5501 |
Add the agent_policy_id and policy_revision_idx attributes to checkin requests.
michel-laterman
force-pushed
the
feat/checkin-policy-details
branch
from
39f169e to
0721e6f
Compare
michel-laterman
force-pushed
the
feat/checkin-policy-details
branch
from
0721e6f to
cfb5df4
Compare
michel-laterman
commented
Sep 12, 2025
|
|
||
| // Ack sends an ack for the associated action if the results are expected. | ||
| // An ack will not be sent for a POLICY_CHANGE action, but will be when this method is used by UNENROLL actions. | ||
| func (l *policyChange) Ack() error { |
There was a problem hiding this comment.
It may be less confusing to make this a nop, and provide something else for unenroll actions to use
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the agent_policy_id and policy_revision_idx attributes to checkin requests.
These attributes are sources from the action stored as a part of the state.
Why is it important?
The policy information in fleet-server and agent may go out of sync; this may occur in cases where a VM restores from a snapshot.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolDisruptive User Impact
N/A
Related issues