Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 4, 2024

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
sql.clear_cursor 🟢 1/1 1/1
sql.delete_async Missing test Missing test
sql.get_async_status Missing test Missing test
sql.get_async Missing test Missing test
sql.query 🟢 4/4 4/4
sql.translate 🔴 1/1 0/1

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a user December 4, 2024 00:45
@lcawl lcawl marked this pull request as ready for review December 4, 2024 00:45
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
sql.clear_cursor 🟢 1/1 1/1
sql.delete_async Missing test Missing test
sql.get_async_status Missing test Missing test
sql.get_async Missing test Missing test
sql.query 🟢 4/4 4/4
sql.translate 🔴 1/1 0/1

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
sql.clear_cursor 🟢 1/1 1/1
sql.delete_async Missing test Missing test
sql.get_async_status Missing test Missing test
sql.get_async Missing test Missing test
sql.query 🟢 4/4 4/4
sql.translate 🔴 1/1 0/1

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style quibble to consider but LGTM 👍

@lcawl lcawl merged commit 17a6964 into main Dec 4, 2024
7 checks passed
@lcawl lcawl deleted the sql-summary branch December 4, 2024 22:55
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
lcawl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit 17a6964)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit 17a6964)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit 17a6964)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants