-
Notifications
You must be signed in to change notification settings - Fork 112
ES|QL: add include_execution_metadata to the query spec #5328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for the contribution @luigidellaquila! considering ...
* @server_default false
* @aliases include_execution_metadata
*/
include_ccs_metadata?: boolean Also, should this be in |
Thanks for checking @l-trotta Or maybe we should keep both with the respective |
"type": "boolean" | ||
}, | ||
"include_execution_metadata": { | ||
"description": "When set to `true` and performing a cross-cluster or cross-project query, the response will include an extra `_clusters`\nobject with information about the clusters that participated in the search along with info such as shards\ncount.\nThis is a synonym for `include_ccs_metadata`, the two parameters can be used interchangeably but not together.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very familiar with this project, but since we have a distinct file for serverless, should the regular one not include include_execution_metadata
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if include_execution_metadata
has not been marked as only available in stack or serverless, then it will be added to both files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include_execution_metadata
will be available in stateful as well, so I guess it's fine to have a single definition with
* @availability stack ...
* @availability serverless
OK, I went for just adding |
@luigidellaquila thanks for the changes! |
Thanks all! Merging |
Adding
include_execution_metadata
parameter to ES|QL query specification.See elastic/elasticsearch#134446
Closes: #5299