CompositeAggregation.sources expects an array of single-key objects
#5335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
pquentin
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Thank you, great catch! In addition to the server code, this is nicely documented and there's a YAML test for that.
LGTM.
l-trotta
approved these changes
Sep 24, 2025
|
Thanks @flobernd and team for the clarification and fix. We were exactly hitting this bug while migrating from NEST to Thanks again for the support and transparency! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. Also marks
CompositeAggregationSourceas a container since the aggregations are mutually exclusive.This fix as well greatly improves the quality of the generated code for the .NET client (see #8704).
Server code:
https://github.com/elastic/elasticsearch/blob/a59c182f9f7e9d1bf3d6eecbc0e44f24ff91d053/server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesSourceParserHelper.java#L78
No backport, since this is a breaking change for statically typed languages.