Skip to content

Conversation

kderusso
Copy link
Member

elastic/elasticsearch#133576 introduced the concept of a chunk_rescorer to the text_similarity_reranker. This PR ports that API change to the specification.

@kderusso kderusso added the skip-backport This pull request should not be backported label Sep 25, 2025
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Following you can find the validation changes against the target branch for the API.

API Status Request Response
search 🔴 2559/2637 → 2565/2637 2637/2637

You can validate this API yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

As you can see in the automated comment, this fixes 6 search request YAML tests without affecting anything else.

@kderusso kderusso marked this pull request as ready for review September 26, 2025 13:00
@kderusso kderusso merged commit 26397bb into main Sep 26, 2025
8 checks passed
@kderusso kderusso deleted the kderusso/reranking-rescore-chunks branch September 26, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-backport This pull request should not be backported specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants