Skip to content

Fix ml.put_trained_model API #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

Fix ml.put_trained_model API #5363

merged 1 commit into from
Sep 29, 2025

Conversation

pquentin
Copy link
Member

No description provided.

@pquentin pquentin requested review from a team as code owners September 29, 2025 07:29
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation changes against the target branch for the API.

API Status Request Response
ml.put_trained_model 🔴 → 🟢 8/16 → 16/16 16/16

You can validate this API yourself by using the make validate target.

pquentin
pquentin commented Sep 29, 2025
View reviewed changes
specification/ml/_types/inference.ts
/** The field that is added to incoming documents to contain the inference prediction. Defaults to predicted_value. */
results_field?: string
vocabulary: Vocabulary
vocabulary?: Vocabulary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server code: https://github.com/elastic/elasticsearch/blob/afd10f4b70c4616dcfbd54da9daac1bd36ce382d/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/TextExpansionConfig.java#L71-L80

specification/ml/_types/inference.ts
results_field?: string

vocabulary: Vocabulary
vocabulary?: Vocabulary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server code: https://github.com/elastic/elasticsearch/blob/afd10f4b70c4616dcfbd54da9daac1bd36ce382d/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/TextEmbeddingConfig.java#L75-L86

specification/ml/_types/inference.ts
/** The field that is added to incoming documents to contain the inference prediction. Defaults to predicted_value. */
results_field?: string
vocabulary: Vocabulary
vocabulary?: Vocabulary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server code: https://github.com/elastic/elasticsearch/blob/afd10f4b70c4616dcfbd54da9daac1bd36ce382d/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/FillMaskConfig.java#L75-L93

@pquentin pquentin requested a review from l-trotta September 29, 2025 08:16
davidkyle
davidkyle approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pquentin

@pquentin pquentin merged commit 4c1d1a7 into main Sep 29, 2025
11 of 12 checks passed
@pquentin pquentin deleted the fix-ml-put-trained-model branch September 29, 2025 09:27
github-actions bot pushed a commit that referenced this pull request Sep 29, 2025
@pquentin @github-actions
Fix ml.put_trained_model API (#5363)
e35da3a 
(cherry picked from commit 4c1d1a7)
@github-actions github-actions bot mentioned this pull request Sep 29, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Sep 29, 2025
@pquentin @github-actions
Fix ml.put_trained_model API (#5363)
dfd4a96 
(cherry picked from commit 4c1d1a7)
@github-actions github-actions bot mentioned this pull request Sep 29, 2025
Merged
pquentin added a commit that referenced this pull request Sep 29, 2025
@github-actions @pquentin
Fix ml.put_trained_model API (#5363) (#5365)
de8c5c7 
(cherry picked from commit 4c1d1a7)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Sep 29, 2025
@github-actions @pquentin
Fix ml.put_trained_model API (#5363) (#5364)
44909dd 
(cherry picked from commit 4c1d1a7)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

@l-trotta l-trotta l-trotta approved these changes

Assignees
No one assigned
Labels
backport 8.19 backport 9.1 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pquentin @davidkyle @l-trotta