[INFERENCE] Remove node pinning logic #134630
Open
+2
−789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
commented
Sep 12, 2025
| * @param divisor - divisor to divide the initial requests per time unit by | ||
| */ | ||
| public synchronized void updateTokensPerTimeUnit(Integer divisor) { | ||
| private synchronized void updateTokensPerTimeUnit(Integer divisor) { |
There was a problem hiding this comment.
@jonathan-buttner is this code and the related updateRateLimitDivisor() functions still required?
There was a problem hiding this comment.
No I'm pretty sure we only added for the node pinning so we should be able to remove it
There was a problem hiding this comment.
Should we also remove the routed logic here: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/action/BaseInferenceActionRequest.java#L26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request routing logic was added to enable per node rate limiting with the Elastic Inference Service but that code remained behind a feature flag and was never enabled. EIS now implements rate limiting make the code redundant.