OTLP: return correct response type for partial successes #137718
Merged
+110
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now returns an ExportMetricsServiceResponse with an embedded ExportMetricsPartialSuccess rather than a plain ExportMetricsServiceResponse. This also limits the size of the error message to avoid decoding issues in the collector. For indexing errors, it returns one sample error message per unique index and status code. It also limits the number of ignored data point messages to 10.
elasticsearchmachine
added
Team:StorageEngine
v9.3.0
external-contributor
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
felixbarny
added
auto-backport
Collaborator
|
Hi @felixbarny, I've created a changelog YAML for you. |
kkrik-es
reviewed
Nov 10, 2025
...tel-data/src/main/java/org/elasticsearch/xpack/oteldata/otlp/OTLPMetricsTransportAction.java
Show resolved
Hide resolved
kkrik-es
approved these changes
Nov 10, 2025
Collaborator
💚 Backport successful
|
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Nov 10, 2025
) Now the action returns an ExportMetricsServiceResponse with an embedded ExportMetricsPartialSuccess rather than a plain ExportMetricsServiceResponse. This also limits the size of the error message to avoid decoding issues in the collector. For indexing errors, it returns one sample error message per unique index and status code. It also limits the number of ignored data point messages to 10.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 10, 2025
…137827) Now the action returns an ExportMetricsServiceResponse with an embedded ExportMetricsPartialSuccess rather than a plain ExportMetricsServiceResponse. This also limits the size of the error message to avoid decoding issues in the collector. For indexing errors, it returns one sample error message per unique index and status code. It also limits the number of ignored data point messages to 10.
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Nov 10, 2025
) Now the action returns an ExportMetricsServiceResponse with an embedded ExportMetricsPartialSuccess rather than a plain ExportMetricsServiceResponse. This also limits the size of the error message to avoid decoding issues in the collector. For indexing errors, it returns one sample error message per unique index and status code. It also limits the number of ignored data point messages to 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now returns an ExportMetricsServiceResponse with an embedded ExportMetricsPartialSuccess rather than a plain ExportMetricsServiceResponse.
This also limits the size of the error message to avoid decoding issues in the collector. For indexing errors, it returns one sample error message per unique index and status code. It also limits the number of ignored data point messages to 10.
Example error message from the collector: