SearchQueryThenFetchAsyncAction - close properly byte stream on failure #137810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drempapis
added
>refactoring
auto-backport
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
benchaplin
approved these changes
Nov 10, 2025
Contributor
benchaplin
left a comment
benchaplin
left a comment
There was a problem hiding this comment.
Looks good thanks Dimi, I missed this piece in my recent change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing the class, I noticed that the
onShardDonemethod has a potential leak on the exception path.If
writeSuccessfulResponse(out)orwriteReductionFailureResponse(...)throws, the code enters thecatch (IOException e)block and returns without releasingout.In the success path, ownership of the buffer is correctly transferred via
out.moveToBytesReference()andActionListener.respondAndRelease(...), which ensures the bytes are released. However, in the failure path, the stream remains open and its underlying buffer is never returned to the recycler.