Skip to content

Conversation

@luigidellaquila
Copy link
Contributor

@luigidellaquila luigidellaquila commented Nov 10, 2025

Add CPS settings both to EQL action and to inner field_caps invocation

PIT is not ready for it yet, it will be managed with a follow-up PR

@luigidellaquila luigidellaquila changed the title EQL: enable CPS - tests take 2 EQL: enable CPS Nov 10, 2025
@luigidellaquila luigidellaquila marked this pull request as ready for review November 10, 2025 15:05
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @luigidellaquila, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Nov 10, 2025
@luigidellaquila
Copy link
Contributor Author

@piergm It seems to work fine, but I have a doubt: I changed indicesOptions for the field_caps call (fan-out), but not for the subsequent _search calls. Should I also do it in that case?

This is where I prepare the search requests: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/execution/search/RuntimeUtils.java#L189-L196

@piergm
Copy link
Member

piergm commented Nov 11, 2025

@luigidellaquila I have to take a deeper look, but I think we should do the same as we do for the field caps call.
My theory on why it's currently working is because both PIT (so MRT=false) and _search with MRT=true are not CPS enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/EQL EQL querying >enhancement serverless-linked Added by automation, don't add manually Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants