Upgrade refractor dependency to v5.0.0
#8618
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updates usages to align with changed API - updates jest config to ensure ESM-only dependencies are transformed to commonjs
mgadewoll
force-pushed
the
build/8616-upgrade-refractor
branch
from
a110a66 to
aaf53b6
Compare
💚 Build SucceededHistory
cc @mgadewoll |
💚 Build Succeeded
cc @mgadewoll |
|
Related to elastic/synthetics-recorder#548, we'd love to see a Refractor upgrade for the Script Recorder as well, which is a consumer of EUI 🎉 |
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
❌ We're automatically closing this PR due to lack of activity. Please comment if you feel this was done in error. |
github-actions
bot
added
the
stale-pr-closed
github-actions
bot
removed
stale-pr-closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #8616
This PR updates the
refractordependency from the previous version3.6.0to the latest5.0.0.The change is required to ensure that the internal
primsjmdependency is using at least version1.30.0which includes a fix for a DOM Clobbering vulnerability. (see also this previous PR that updated our directprismjsdependency)Changes
refractorchanged it's default exports and removed types (RefractorNodeetc) - instead we import the types directly from the internal dependency (as mentioned here in the changelog)transformIgnorePatternsand manual transform ofrefactorcode asrefractorchanged its internals and only exports as ESM but Jest requires commonjsQA
ℹ️ I ran VRT on the affected components, and no visual changes were detected.
EuiCodeEuiCodeBlockEuiMarkdownFormatEuiMarkdownEditor