-
Notifications
You must be signed in to change notification settings - Fork 860
[Flyout System] Integrate unmanaged EuiFlyout animations with state transition animations of managed flyouts #9015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flyout System] Integrate unmanaged EuiFlyout animations with state transition animations of managed flyouts #9015
Conversation
6c9eac3 to
d811dac
Compare
…lyout resizable when `resizable=true`
…eFlyoutActivityStage`
- unnecessary EuiMenuMenu in stories - duplicate key in interface
b36b43d to
b528850
Compare
@tkajtoch @acstll I'm concerned the I don't see a problem with it temporarily, but long-term we should make it as easy as possible to switch existing flyouts into managed session flyouts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR and I think I have a fix for the bug where the "child" flyout of a previous session stays visible when the next session is loaded.
packages/eui/src/components/flyout/manager/flyout_managed.styles.ts
Outdated
Show resolved
Hide resolved
packages/eui/src/components/flyout/manager/flyout_fill_mode.stories.tsx
Outdated
Show resolved
Hide resolved
|
When I apply this fix: #9052 into this branch, I see an issue with using a fill-mode main flyout and opening a child. The session does not apply the calculated resizes until the child animation is done. animation-bug-fill-mode-with-child.mov |
Co-authored-by: Tim Sullivan <[email protected]>
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
I double-checked and, if I'm not mistaken,
@tsullivan that means we can merge this now (if we consider the bug described above minor)? |
I've also checked and can confirm this. I initially got concerned from looking at the changes to the storybook files. When I tested locally without the changes made to the storybook files, everything does still work, but the opening of flyouts isn't animated.
Yes, that bug is minor. I'm OK with approving this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for double-checking everything in regards to the isOpen prop
|
Apart from the issue found by @tsullivan, described above, I found another one I'll post below. This we would need to double-check and if needed, create a separate issue. (Posting here because it's related.)
Kapture.2025-09-26.at.16.31.23.mp4cc @tkajtoch |
Summary
Note: This PR targets the
feat/flyout-systemfeature branch and needs rebasing. Please review #9025 first.Resolves #8990
Why are we making this change?
As part of the Flyout System work, we need to update and improve flyout animations. This work includes:
isOpenprop and calladdFlyoutandcloseFlyoutaccordinglyImpact to users
This PR gets merged into a feature branch, and the work is considered WIP. There's no impact to users at this point other than the temporary removal of
EuiOverlayMaskfromEuiFlyoutthat'll be re-added in #8989.QA
Please note that the shopping cart storybook example is outdated and doesn't reflect the expected real world usage of the flyout system. It's expected that closing the Item details flyout is not animated when closing the Shopping cart flyout.
/?path=/story/layout-euiflyout-flyout-manager--flyout-child-demo(link TBD) and confirm the opening and closing of main and child flyouts is fully animated and there's no "choppiness" observed/?path=/story/layout-euiflyout-flyout-manager--fill-modeand confirm the opening and closing offillsize flyouts animates as expectedGeneral checklist