[ER] Enhancement for Cisco IOS XR Integration #15865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rationale Because the grok_header was too finicky decided to move parsing down to grok_message_at_top_level - able to isolate message and a dedicated grok pattern for pulling out hostname - generated pipeline tests for the new message formats - handled the space/no space separation for the dissect_login scenario - fixed missing ecs fields, related.hosts and source.domain
qcorporation
added
bug
qcorporation
changed the title
With the proper PR number
andrewkroh
added
the
documentation
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
qcorporation
commented
Nov 4, 2025
packages/cisco_ios/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
jrmolin
approved these changes
Nov 4, 2025
packages/cisco_ios/data_stream/log/_dev/test/pipeline/test-syslog.log-expected.json
Outdated
Show resolved
Hide resolved
packages/cisco_ios/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
- removed the second step parsing in grok_message_at_top_level - added another top level grok_header pattern that can parse out hostname, old messages also get a benefit that timestamps are populated
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
Package cisco_ios - 1.33.0 containing this change is available at https://epr.elastic.co/package/cisco_ios/1.33.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Because the grok_header was too finicky decided to move parsing down to grok_message_at_top_level
related.hostsandsource.domainChecklist
changelog.ymlfile.Related issues