#1321 add CEST and CET timezone to TZ #1378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for the record, this is a replacement PR for #1321 which was closed as dupliate. |
|
Looks good. I'd like a second opinion on the actual regexp, @jordansissel ? basically, my reserve is that there are far more valid timezone still not covered in this regexp - how important is it to actually match on valid tokens instead of simply matching on 3-4 chars? then the question becomes, what are the chances of having a date with an invalid timezone code? |
|
Can one of the admins verify this patch? |
jordansissel
force-pushed
the
master
branch
from
f86287d to
a536eef
Compare
|
@dgouyette since we're moving the plugins to separate repositories, would you mind reopening this PR in https://github.com/logstash-plugins/logstash-filter-grok? Thanks! |
|
migrated issue to logstash-plugins/logstash-patterns-core#16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.