Skip to content

Conversation

p1gp1g
Copy link
Contributor

@p1gp1g p1gp1g commented Mar 2, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

The Widget API was not correctly injected to allowed widgets.

Motivation and context

This fixes #3892 .
It can be considered has a partial fix for this issue since widget can't send stickers at this moment, but this is a different issue. [Edit: widgets are now able to send stickers, with the ActivityResultLauncher]

The changes are needed to use https://github.com/torinreilly/matrix-gif-keyboard and/or https://github.com/maunium/stickerpicker (and very probably others) as a widget.

Tests

  • On element-web/desktop : /addwidget https://maunium.net/stickers-demo/
  • Try to access it on element-android

Tested devices

  • Physical
  • Emulator
  • OS version(s): 9

Checklist

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Mar 2, 2022
@bmarty bmarty requested a review from ganfra March 10, 2022 19:41
@bmarty bmarty closed this Apr 15, 2022
@bmarty bmarty reopened this Apr 15, 2022
@bmarty
Copy link
Member

bmarty commented Apr 15, 2022

(Closed and reopened to wake up the CI)

@bmarty
Copy link
Member

bmarty commented Jul 1, 2022

This looks like a decent PR to merge. Just trying to wake the CI again.

@bmarty bmarty closed this Jul 1, 2022
@bmarty bmarty reopened this Jul 1, 2022
@p1gp1g
Copy link
Contributor Author

p1gp1g commented Aug 8, 2022

Rebased + Linted

@p1gp1g
Copy link
Contributor Author

p1gp1g commented Aug 8, 2022

The last commit may be separated to a new PR but these changes fix the related issues

Signed-off-by: sim <[email protected]>
@p1gp1g
Copy link
Contributor Author

p1gp1g commented Aug 18, 2022

@bmarty I don't know if I should have highlighted you to ask a new review so I'm doing it now. Sorry for the noise if I shouldn't have.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Room widgets have no access to postMessage API

3 participants