Skip to content

Conversation

byquanton
Copy link
Contributor

@byquanton byquanton commented Aug 29, 2025

  • Updated setDisplayMediaRequestHandler to detect XDG_SESSION_TYPE=wayland
  • Enabled { useSystemPicker: true } for macOS 15+ native picker

Should fix #1750, #1913, #2205

Checklist

  • Ensure your code works with manual testing.
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@byquanton byquanton requested a review from a team as a code owner August 29, 2025 20:49
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 29, 2025
@t3chguy
Copy link
Member

t3chguy commented Sep 5, 2025

I think CI is unhappy because you used the develop branch so it'll be matching against your https://github.com/byquanton/element-web/tree/develop fork branch which is really far behind. I suggest either updating that branch or changing your contribution branch here.

- Updated `setDisplayMediaRequestHandler` to detect `XDG_SESSION_TYPE=wayland`
- Enabled `{ useSystemPicker: true }` for macOS 15+ native picker
@byquanton
Copy link
Contributor Author

I've updated my element-web repo.

@t3chguy
Copy link
Member

t3chguy commented Sep 8, 2025

@byquanton seems like you have a lint/prettier failure

@t3chguy t3chguy merged commit 56e3e83 into element-hq:develop Sep 9, 2025
31 checks passed
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Sep 23, 2025
https://build.opensuse.org/request/show/1306768
by user dheidler + anag_factory
- Fix fix-oxc-resolver.patch
- Version 1.12.0
  ## 🦖 Deprecations
  * Remove remaining support for outdated .well-known settings (element-hq/element-web#30702). Contributed by @richvdh.
  ## ✨ Features
  * Automatically select first source for desktop capture under Wayland (element-hq/element-desktop#2526). Contributed by @byquanton.
  * Add decline button to call notification toast (use new notification event) (element-hq/element-web#30729). Contributed by @toger5.
  * Use the new room list by default (element-hq/element-web#30640). Contributed by @langleyd.
  * "Verify this device" redesign (element-hq/element-web#30596). Contributed by @uhoreg.
  * Set Element Call "int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen sharing fails on Wayland
4 participants