Update Electron to v38.0.0 to fix Kernel crash on multi-GPU systems

[Arcitec]

Closes #2543

Checklist

• Ensure your code works with manual testing.
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

[Arcitec]

I have tested it locally on my machine and it runs perfectly after this fix.

Tested:

• Native, local binary.
• Flatpak.
• Both of them finally work properly after the Electron update.

The yarn.lock is re-created with your current package.json specification exactly as seen in the pull request.

[t3chguy]

By recreating the yarn lock file You updated unrelated dependencies which now mean the linter is unhappy due to some changes in those dependencies, I suggest not doing that.

[Arcitec]

@t3chguy Hmm. What do you suggest doing then? Updating a package.json without updating yarn.lock has no effect. And the only way to update a dependency (such as Electron) is to re-create yarn.lock, since Electron itself can have newer requirements. So doing manual surgery inside yarn.lock isn't recommended either.

I can remove the yarn.lock file changes and only include the package.json change. Or do you have any other solution?

Edit: Either way, those breaking in changes the other dependencies are not good (sounds like your package.json might need to restrict the version-selector for a few more dependencies), so I'll revert the yarn.lock change and force push just the package.json file now.

[Arcitec]

Judging by the previous run log, it seems the issue was that Unicorn ("eslint-plugin-unicorn": "^56.0.0") became updated and no longer contains a unicorn/no-instanceof-builtins. It's strange that they would remove a rule without marking it as a breaking change.

https://github.com/element-hq/element-desktop/actions/runs/17528024776/job/49782843428

Edit: They still list it as a valid rule. So I have no idea why that rule cannot be found by the linter... 🤷‍♂️

[t3chguy]

Normally just using yarn add electron@version would be enough to do everything for you.

[t3chguy]

If you cannot figure it out then we can use #2545 instead

[t3chguy]

I'm not sure we can update right now anyway, as the v38 changelog says "For breaking changes inherited via Chromium, see blog post" and then there is no blog post...

[Arcitec]

@t3chguy Ah, I wasn't aware that yarn add can be used for conservative updates. I've always rebuilt the yarn.lock file. :')

I've done that surgical upgrade now and updated this PR. yarn lint passes.

But since the bot has now also prepared a pull request that updates sentry and a lot more dependencies, that might be a better PR if you prefer a newer sentry too.

Regarding the lack of breaking change news, I agree that it's worth waiting until Electron has written a summary of any breaking changes. I'm not seeing any errors in my test usage though, and the linked Chromium + Node changes don't seem to mention anything serious here: https://releases.electronjs.org/release/v38.0.0