Listen to call decline to stop ringing when declined from other device

[BillCarsonFr]

Pull Request Checklist

Fixes Fixes #4493
Based on #4499

• I read the contributing guide.
• Pull request contains a changelog label.

UI changes have been tested with:

• iPhone and iPad simulators in portrait and landscape orientations.
• Dark mode enabled and disabled.
• Various sizes of dynamic type.
• Voiceover enabled.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.16%. Comparing base (3fa133c) to head (cae1e62).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...rces/Services/ElementCall/ElementCallService.swift	0.00%	37 Missing ⚠️
ElementX/Sources/Other/SDKListener.swift	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4505      +/-   ##
===========================================
- Coverage    79.18%   79.16%   -0.03%     
===========================================
  Files          836      836              
  Lines        78731    78758      +27     
===========================================
- Hits         62347    62346       -1     
- Misses       16384    16412      +28     

Flag	Coverage Δ
unittests	71.51% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pixlwave]

Thanks for the PR, looks like a neat feature 🙌

I chatted with Stefan about the new DeclineCallbackPublisher and we concluded that as there is only a single usage, the additional complexity probably isn't worth it. We're perfectly happy to follow the same pattern for these as we do for e.g. knocking, typing etc by subscribing and exposing a single publisher:

element-x-ios/ElementX/Sources/Services/Room/JoinedRoomProxy.swift

Lines 20 to 21 in df47858

	// periphery:ignore - required for instance retention in the rust codebase
	private var typingNotificationObservationToken: TaskHandle?

element-x-ios/ElementX/Sources/Services/Room/JoinedRoomProxy.swift

Lines 59 to 62 in df47858

	private let typingMembersSubject = CurrentValueSubject<[String], Never>([])
	var typingMembersPublisher: CurrentValuePublisher<[String], Never> {
	typingMembersSubject.asCurrentValuePublisher()
	}

element-x-ios/ElementX/Sources/Services/Room/JoinedRoomProxy.swift

Lines 120 to 130 in df47858

	Task {
	subscribeToRoomInfoUpdates()
	subscribeToTypingNotifications()
	await subscribeToKnockRequests()
	if infoPublisher.value.isEncrypted {
	await subscribeToIdentityStatusChanges()
	}
	}

element-x-ios/ElementX/Sources/Services/Room/JoinedRoomProxy.swift

Lines 719 to 735 in df47858

	private func subscribeToTypingNotifications() {
	typingNotificationObservationToken = room.subscribeToTypingNotifications(listener: RoomTypingNotificationUpdateListener { [weak self] typingUserIDs in
	guard let self else { return }
	MXLog.info("Received typing notification update, typingUsers: \(typingUserIDs)")
	let typingMembers = typingUserIDs.compactMap { userID in
	if let member = self.membersPublisher.value.filter({ $0.userID == userID }).first {
	return member.displayName ?? member.userID
	} else {
	return userID
	}
	}
	typingMembersSubject.send(typingMembers)
	})
	}

[pixlwave]

LGTM, thanks for the updates.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud