Skip to content

Allow atoms (interpolated or not) as source in field/2 #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2025
Merged

Allow atoms (interpolated or not) as source in field/2 #4663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/ecto/query/api.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,10 @@ defmodule Ecto.Query.API do
@doc """
Allows a field to be dynamically accessed.

The source name can be a binding (`p` in `from p in Post`) or a named binding
using `as/1` or `parent_as/1`. The named binding maybe a literal atom or an
interpolation.

The field name can be given as either an atom or a string. In a schemaless
query, the two types of names behave the same. However, when referencing
a field from a schema the behaviours are different.
Expand Down Expand Up @@ -633,6 +637,16 @@ defmodule Ecto.Query.API do
where: field(c, ^doors_or_tires) >= 4
end

def at_least_four(query, doors_or_tires) do
from q in query,
where: field(as(:car), ^doors_or_tires) >= 4
end

def at_least_four(query, binding, doors_or_tires) do
from q in query,
where: field(as(^binding), ^doors_or_tires) >= 4
end

In the example above, `at_least_four(:doors)` and `at_least_four("num_doors")`
would be valid ways to return the set of cars having at least 4 doors.

Expand Down
Loading