Skip to content

Fix trailing token crash #14694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix trailing token crash #14694

wants to merge 1 commit into from
+1 −1

Conversation

lukaszsamson
Copy link
Contributor

I noticed this crash in the logs. I'm not sure what input produced that error.

an exception was raised:
    ** (FunctionClauseError) no function clause matching in Code.Fragment.drop_tokens_2
        (elixir 1.18.3) <REDACTED: user-file-path>:1209: Code.Fragment.drop_tokens([], 2)
        (elixir 1.18.3) <REDACTED: user-file-path>:1184: Code.Fragment.container_cursor_to_quoted_2

@josevalim
Copy link
Member

@lukaszsamson plesse rebase or swap branches? :)

@lukaszsamson lukaszsamson force-pushed the ls-fix-trailing-token-crash branch from 992adf9 to b2dd7d9 Compare August 5, 2025 10:24
@josevalim
Copy link
Member

Can we add a failing test please? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszsamson @josevalim