fix(engine): handle failing build script #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the build script fails for some reason, the EngineNode hung, because the :EXIT would not be received, as the Port was started in some other process, but not in the EngineNode's GenServer. Only the latter explicitely traps exits. To fix this without causing any side effects (handle_info(:EXIT) in Node), we run the Port in a Task subprocess that traps exits. Additionally, we log the last line received from the build script to help the user to debug the issue, instead of failing silently with exit reason :normal.
niklas
changed the title
niklas
changed the title
mhanberg
changed the title
mhanberg
changed the title
mhanberg
reviewed
Nov 2, 2025
|
|
||
| {^port, _data} -> | ||
| wait_for_engine(port) | ||
| {^port, {:data, data}} -> |
Member
There was a problem hiding this comment.
It might also help if we log the build output here.
doorgan
approved these changes
Nov 7, 2025
Collaborator
doorgan
left a comment
doorgan
left a comment
There was a problem hiding this comment.
Tested and works well, I get the right message in my nvim lsp logs:
[ERROR][2025-11-07 16:10:14] ...lsp/handlers.lua:562 "Couldn't find an elixir executable for project at /Users/dorgan/dev/rainet. Using shell at ...
doorgan
force-pushed
the
handle-failed-build-script
branch
from
4024e78 to
adcc556
Compare
doorgan
force-pushed
the
handle-failed-build-script
branch
from
0c54eda to
1e893ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the build script fails for some reason, the EngineNode hung, because the :EXIT would not be received, as the Port was started in some other process, but not in the EngineNode's GenServer. Only the latter explicitely traps exits.
To fix this without causing any side effects (handle_info(:EXIT) in Node), we run the Port in a Task subprocess that traps exits.
Additionally, we log the last line received from the build script to help the user to debug the issue, instead of failing silently with exit reason :normal.