Update to use built in Elm-style routing #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current codebase uses
onClickevent listeners onatags. This PR updates the project to use the built in elm internal routing update functions. Additionally, the view function applies the same title to every page which isn't ideal for SEO. As we prepare for the Speakers pages, having this setup will improve SEO. The Model now hasrouteinstead ofurl.NOTE: If we merge this first, I can update the speakers info PR. There are a lot of formatting diffs that elm-format is automating and i don't want to mess with my editor setup to disable the formatting that I think we should prob have anyway.