Add support for rewriting map files #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map files have a `file` attribute that contains the filename of the minified Javascript file they describe. Everything else in the map file is a description of the source code, and shouldn't get re-written. This commit adds custom processing for map files so that if `.map` is included in `replaceExtensions` the correct processing will occur. I did not add `.map` to the default `replaceExtensions` as that is more of an invasive change from a compatibility standpoint than I really want to make without more demand for this functionality and/or confirmation that it works in use cases other than mine.
Author
|
cc @rwjblue per our slack discussion -- let me know what you think |
Author
|
Oh, just noticed this will fit well with the direction of #52 (although they will have to be merged at some point). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map files have a
fileattribute that contains the filename of the minified Javascript file they describe. Everything else in the map file is a description of the source code, and shouldn't get re-written. This commit adds custom processing for map files so that if.mapis included inreplaceExtensionsthe correct processing will occur.I did not add
.mapto the defaultreplaceExtensionsas that is more of an invasive change from a compatibility standpoint than I really want to make without more demand for this functionality and/or confirmation that it works in use cases other than mine.