dynamic notch on pidsum #797
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick-Flash
added
enhancement
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
2 times, most recently
from
07ddd2b to
7015291
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
2 times, most recently
from
4a922e6 to
64a1957
Compare
nerdCopter
force-pushed
the
dynamic-notch-on-pidsum-not-gyro
branch
from
6511da5 to
6821359
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
2 times, most recently
from
0c4ee8b to
3aab740
Compare
nerdCopter
force-pushed
the
dynamic-notch-on-pidsum-not-gyro
branch
from
6821359 to
225cc8b
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
3aab740 to
e86e758
Compare
nerdCopter
force-pushed
the
dynamic-notch-on-pidsum-not-gyro
branch
from
225cc8b to
36309c1
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
2 times, most recently
from
fe70257 to
fe7710c
Compare
gyro->pidum is not a linear change. dynamic notch on pidsum might better account for dterm and other dynamics going on.
nerdCopter
force-pushed
the
dynamic-notch-on-pidsum-not-gyro
branch
from
36309c1 to
8182e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going from gyro to pid adds a lot of nonlinear changes to the signal, therefore gyro filtering and pidsum filtering are different. Dynamic dterm, tpa, and more all have different effects on the pidsum. By running the dynamic notch on the pidsum instead of on the gyro we can better account for the effect that pids have on the signal. AKA this will filter PID, just like we do when filtering the gyro, but it will better filter for the specific ratio of PID and any extra dynamics like TPA, anti-gravity, etc. In other words this in theory should work a bit better than just filtering the gyro with a dynamic notch.