Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Conversation

abetkin
Copy link

@abetkin abetkin commented Sep 11, 2019

No description provided.

@abetkin abetkin changed the title Fix typo (tests are missing!) Use query.params() for selectable queries Sep 26, 2019
@lovelydinosaur
Copy link
Member

Heya - thanks for this!
Could we get a test case and a brief explanation?

@abetkin
Copy link
Author

abetkin commented Sep 30, 2019

added a test

@abetkin
Copy link
Author

abetkin commented Oct 13, 2019

@tomchristie ping

@garyd203
Copy link

garyd203 commented Jan 7, 2020

Hey @abetkin thanks for fixing this, I ran into the same problem :-). FWIW I have worked around the problem by doing database.fetch_all(select_query.params(foo=1))

By the way, I notice that the test run failed simply because of file formatting in test_databases.py (perhaps just not enough new lines).

@lovelydinosaur
Copy link
Member

There's a linter failure on this pull request at the moment.
Running scripts/lint would resolve this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants