Add ENSv2 section to contracts documentation. #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for ENSv2 in the contracts index page.
Arachnid
changed the title
Deploying ens-docs with
|
| Latest commit: |
5c32f7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3a123177.docs-bao.pages.dev |
| Branch Preview URL: | https://feat-ensv2-docs.docs-bao.pages.dev |
schmidsi
reviewed
Jun 11, 2025
| which are represented as tokens. Because of the hierarchical nature of the registry structure as demonstrated | ||
| above, merely owning a subname token on a registry does not guarantee anything in isolation: to be meaningful, | ||
| the registry must be referenced by a parent registry, and so on up to the root registry. Client authors must | ||
| therefore take care in how they represent names to users, to ensure users are not given a false impression |
There was a problem hiding this comment.
I think here it would be helpful to give an example. Like "Ownership of domingo.wallet.eth does not guarantee X"
|
|
||
| When a subname is transferred to a new owner, any roles that were granted to the previous owner are automatically | ||
| transferred to the new owner, but roles granted to other accounts remain unmodified - so it is important that | ||
| apps facilitating trading of names verify the set of roles granted to external accounts. |
There was a problem hiding this comment.
Reading this, I get a bit afraid that some apps that trade names will miss doing this properly. How can we enforce that?
| | Package | Description | | ||
| | ------- | ----------- | | ||
| | [Registries](./registries) | Registries govern ownership of names | | ||
| | [Resolvers)(./resolvers) | Resolvers control how a name is converted to a resource | |
There was a problem hiding this comment.
It seems like there is a bug with relative links. So I just used absolute links for now.
gskril
reviewed
Aug 22, 2025
|
Merging the overview file for now with the expectation of re-adding registry and resolver docs in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new section for ENSv2 in the contracts index page.