Skip to content

Conversation

@AdRiley
Copy link
Member

@AdRiley AdRiley commented Oct 7, 2025

Pull Request Description

This pull request introduces a new can_write_into_parent method

The main goal is to ensure that write operations fail gracefully with a clear error if the parent directory does not exist

For AWS files the existence of "directories" is not so relevant to we just check if the bucket exists.

Fixes #11516

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 7, 2025
@AdRiley AdRiley force-pushed the wip/adr/add-folder-not-found-error-for-excel branch from fd54982 to 078b659 Compare October 15, 2025 08:42
@github-actions github-actions bot added the -libs-API-change-AWS Marks a PR that changes the public API of Standard.AWS label Oct 22, 2025
@AdRiley AdRiley marked this pull request as ready for review October 22, 2025 10:30
@github-actions github-actions bot added -libs-API-change-Base Marks a PR that changes the public API of Standard.Base labels Oct 23, 2025
@AdRiley AdRiley merged commit 31fa391 into develop Oct 23, 2025
101 of 106 checks passed
@AdRiley AdRiley deleted the wip/adr/add-folder-not-found-error-for-excel branch October 23, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-libs-API-change-AWS Marks a PR that changes the public API of Standard.AWS -libs-API-change-Base Marks a PR that changes the public API of Standard.Base CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message when writing an Excel file to a nonexistent directory

3 participants