Move modules out of common
#14168
Move modules out of common
#14168
Conversation
somebody1234
requested review from
Frizi,
farmaazon,
kazcw and
vitvakatu
as code owners
somebody1234
added
the
CI: No changelog needed
There was a problem hiding this comment.
backendQuery is also used only in GUI, so why it is not moved?
| const firstDate = firstProjectExecutionOnOrAfter(projectExecution, startDate) | ||
| if (firstDate.compare(endDate) > 0) { | ||
| return EMPTY_ARRAY | ||
| return [] |
| async (err, { https: httpsServer, http: httpServer }) => { | ||
| const server = httpsServer ?? httpServer | ||
| if (process.env.ELECTRON_DEV_MODE === 'true') { | ||
| const vite = (await import( | ||
| pathToFileURL(process.env.NODE_MODULES_PATH + '/vite/dist/node/index.js').href | ||
| )) as typeof import('vite') | ||
| this.devServer = await vite.createServer({ | ||
| server: { | ||
| middlewareMode: true, | ||
| hmr: server ? { server } : {}, | ||
| }, | ||
| configFile: process.env.GUI_CONFIG_PATH ?? false, | ||
| mode: process.env.MODE ?? 'staging', | ||
| }) | ||
| } | ||
| if (err) { | ||
| console.error('Error creating server:', err.http) | ||
| reject(err) | ||
| } | ||
| resolve() |
There was a problem hiding this comment.
This change is not mentioned in the description, and I’m confused. What are we doing here?
There was a problem hiding this comment.
my bad, this brings back code that was incorrectly removed in some other commit. it's used for the dev server on electron watch mode
There was a problem hiding this comment.
I guess you fixed electron dev mode? Is it working now?
|
E-Hern Lee reports a new STANDUP for the provided date (2025-10-16): Progress: - refactor It should be finished by 2025-10-23. |
somebody1234
added
the
CI: Ready to merge
|
E-Hern Lee reports a new STANDUP for the provided date (2025-10-17): Progress: - finish refactor It should be finished by 2025-10-23. |
Pull Request Description
commonmodules only used ingui, intoguiImportant Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.