-
Couldn't load subscription status.
- Fork 334
Bump Rust version to stable 1.90.0 #14171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to wip/frizi/rust-stable-1.90.0 # Conflicts: # build.sbt
Maybe this will fix this weird error: https://github.com/enso-org/enso/actions/runs/18651537922/job/53170507547?pr=14171#step:10:1691
Cargo error: `debug` is reserved profile.
This reverts commit 2fe1319.
This reverts commit b036f3d.
|
Please run the nightly workflow to verify the release artifacts |
|
Overnight:
Rerunning to verify flakiness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally removed wasm-bindgen-test run, since the remaining singular test was a copy of native test anyway, adding no value.
This test is important, actually. It is the crux of our current strategy for ensuring the parser cannot be crashed by inputs with deep nesting.
See here:
enso/lib/rust/parser/src/format.rs
Lines 38 to 41 in dcb9310
| /// Maximum allowed nesting depth of compound objects. This is empirically determined to be reached | |
| /// before stack overflow on supported targets (see [`test::test_infinite_recursion`] and | |
| /// [`test::wasm::test_infinite_recursion`]). | |
| const RECURSION_LIMIT: usize = 1024; |
If we really need to remove this test, we should first ensure that RECURSION_LIMIT is well below the value that would currently allow stack overflows, to reduce the risk that future changes cause a regression in our crash-safety; and we should update the docs to no longer suggest that we are protected by this test. However lowering the limit to rely on a larger safety margin would reject more valid programs than we can accept with a level that is validated by testing.
|
We could bring back the wasm-bindgen test, but I'd like to keep it removed just in order to simplify the CI pipeline a bit. We also run the built parser within the GUI tests, so we could create a unit test in GUI that attempts a parse of very nested expression and check for the expected "recursion limit" to be returned. Also, the stack size of wasm module is configurable. |
|
I think we can bring back the test and add a short manually written workflow that runs |
|
I’m getting a consistent failure of I have no explanation why this happens: nightly builds against develop succeed.
|
|
Exactly the same failure is now happening on https://github.com/enso-org/enso/actions/runs/18767774530/job/53549155638 |
Pull Request Description
All other code changes are caused by formatting changes, dead code removal or new clippy lint rules finding trivial replacements.
Important Notes
The few remaining
#[bench]tests were the only thing that depended on running nightly. Since we don't run them in CI anyway, they are now hidden under a "nightly" flag and can be manually enabled when running them locally. We can migrate them to criterion if desired, but the scope of that change would be significantly bigger.