-
Notifications
You must be signed in to change notification settings - Fork 4
Remove Capnp as a Required Dependency #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JonoPrest
wants to merge
12
commits into
main
Choose a base branch
from
jp/remove-capnp-dep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3be3266
Implemenent capnp codegen by flag
JonoPrest 7e8f3d2
Adds CI and documentation
JonoPrest a2991c6
Move capnp build to make file
JonoPrest 97d7b43
Fix broken tests from merge
JonoPrest 3001eed
Fix clippy warnings
JonoPrest 4b69bcf
Remove ci capnproto deps
JonoPrest 60f63c2
Fix ci
JonoPrest 8683dd1
Format generated
JonoPrest 424e61c
Fix last clippy warning
JonoPrest bcf9596
Call capnpc directly
JonoPrest a29a954
Enforce use of capnp 1.1.0
JonoPrest 6c403a3
Updated dockerfile entry point
JonoPrest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# hypersync-net-types | ||
|
||
This crate contains the capnp schema for the hypersync network protocol. | ||
|
||
## Building | ||
|
||
To build the schema, run the following command: | ||
|
||
```bash | ||
make capnp-build | ||
``` | ||
|
||
This will generate the `hypersync_net_types_capnp.rs` file in the `src` directory. | ||
|
||
The build script will not run on every build, so you will need to run it manually if you make changes to the schema. | ||
|
||
The ci tests will fail if the schema is not up to date. | ||
|
||
This is to avoid the need to have a capnp compiler installed on the consumers of this crate. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
.PHONY: capnp-build | ||
|
||
capnp-build: | ||
cargo install capnpc | ||
capnp compile -orust:src hypersync_net_types.capnp | ||
rustfmt -- src/hypersync_net_types_capnp.rs |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should prove that capnproto does not need to be included