Skip to content

Conversation

jlojosnegros
Copy link

Persistent memory leaks were found on Envoy.
Updating these dependency versions makes memory consumption more stable.

  • com_github_nlohman_json
  • con_github_datadog_dd_trace_cpp
  • com_github_facebook_zstd

Risk Level: Low
Testing:

  • Use fortio to send 2000 qps with 10 threads for 5m0s and see how memory increase before changes while it does not after changes

Persistent memory leaks were found on Envoy.
Updating these dependency versions makes memory consumtion more stable.

- com_github_nlohman_json
- con_github_datadog_dd_trace_cpp
- com_github_facebook_zstd

Signed-off-by: Jose Luis Ojosnegros <[email protected]>
@jlojosnegros jlojosnegros marked this pull request as ready for review September 23, 2025 10:17
@jlojosnegros
Copy link
Author

/cc @twghu

@phlax
Copy link
Member

phlax commented Sep 23, 2025

@jlojosnegros im wondering if these changes should be addressed in envoy itself - altho 1.28 will soon go EOL

@jwendell
Copy link
Member

@jlojosnegros im wondering if these changes should be addressed in envoy itself - altho 1.28 will soon go EOL

I thought 1.28 was already EOL :/

@phlax
Copy link
Member

phlax commented Sep 23, 2025

8/

ah - you are absolutely correct - long since - its 1.32 that is about to EOL - apologies for my confusion

Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build&tests pass fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants