Adjust lispy to changes in Emacs and Org-mode internals #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lispy.el (lispy--function-parse): Update function to a newer object representation. Fix `lispy-flatten'. In Emacs 30, it began to use dedicated type to represent interpreted-function values, `read' function now returns Closure Function Type instead of simple lists for most types that `lispy--function-parse' tries to handle (except macros, at least). See: - https://git.sv.gnu.org/cgit/emacs.git/commit/?id=f2bccae22bd47a2e7e0937b78ea06131711b935a - (elisp) Closure Type - (elisp) Closure Objects Compare (defmacro test-macro (&rest body) ,@Body) (symbol-function 'test-macro) ;; (macro . #[(&rest body) ((\,@ body)) (t)]) with (defun test-defun (x) (+ x 1)) (symbol-function 'test-defun) ;; #[(x) ((+ x 1)) (t)] There's alternative way to mitigate it, by changing end of `lispy--function-str' to: (error (let ((str (cl-prin1-to-string (symbol-function fun)))) (if (string-prefix-p "#f" str) (substring str 2) str))) But it hides the underlying change that needs to be addresed in the future. Partially fixes `lispy-let-flatten' as well, but keywords (&optional, &rest) in function's signature are not recognized correctly.
* lispy.el (lispy--bounds-outline): Replace org-element function with the outline one. In new version of Org mode `org-element-at-point' works only in Org-like buffers
File can be outside of project (so no root) or may not use poetry/pyproject.toml.
* le-python.el (lispy--python-poetry-name): Fix
* le-python.el (lispy--python-poetry-name): Fix logic. (lispy--python-proc): Replace counsel function with built-in project alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lispyto changes in Emacs internals (cae6554).lispyto changes in Org-mode (b41e407).counsel, use built-in functions instead.Please, see more context in each commit message.
It makes all tests pass on Emacs 30.