fix: use connection pool per request #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/deploy-review
|
|
/deploy-review
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Create a single connection pool per request to avoid using too much connections of the dial core.
To do this, DialApiClient is created within the RequestContext to store the aiohttp.ClientSession to use for the requests to the dial core. This session accepts only dial relative urls and already has necessary api-key headers.
Metadata url in the AttachmentLink is now represented as a relative url to be able to use it in the DialApiClient session.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.