-
Notifications
You must be signed in to change notification settings - Fork 452
feat: add fontless to use custom fonts #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
app.use( | ||
'/_fonts', | ||
express.static('build/client/_fonts', { immutable: true, maxAge: '1y' }), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not happy about these lines, which I had to add for making it work in dev mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Could you also update the documentation on fonts?
app.use( | ||
'/_fonts', | ||
express.static('build/client/_fonts', { immutable: true, maxAge: '1y' }), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind
@kentcdodds docs updated! |
9d8d843
to
46aa828
Compare
46aa828
to
889d124
Compare
I was about ready to merge this and then I noticed when I started the dev server we get a bunch of warnings from MSW I would like you to clean up:
Two things:
|
Saw this blog post about fontless here https://qwik.dev/blog/fontless/, and got interested it to get in the epic-stack.
Test Plan
Checklist
Screenshots