-
Notifications
You must be signed in to change notification settings - Fork 7
Get automated translation from babeldown #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. Results of any additional workflows will appear here when they are done. |
Co-authored-by: CyGei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding to minor edits for consistency
| # installer les packages si elles ne le sont pas déjà | ||
| if (!require("pak")) install.packages("pak") | ||
| if (!require("cfr")) pak::pak("cfr") | ||
| if (!require("epiparameter")) pak::pak("epiparameter") | ||
| if (!require("tidyverse")) pak::pak("tidyverse") | ||
| if (!require("outbreaks")) pak::pak("outbreaks") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Karim-Mane, thanks for this suggestion across your reviews. From deliveries, we have learned that having this script is useful indeed. I have two notes:
- when using {pak} it is not required to use
if(!require())given that {pak} actually have this feedback-loop embeded. So if it is installed, it assesses the version difference. and ask the user. - Some packages require more prereq in case the installation does not work, for that reason we prioritize installation from the main setup page.
So, in order to have this in consideration, let's opt to have it as a spoiler callout (the one that can be collapsed.) This will include a link to the main setup page, where learners will read how to troubleshoot any particular error, and keep that resource centralized, in a way, and do not replicate steps across tutorial pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French edits
|
|
||
| :::::::::::::::::::::::::::::::::::::::::::::::: | ||
|
|
||
| ::::::::::::::::::::::::::::::::::::: objectives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ::::::::::::::::::::::::::::::::::::: objectives | |
| ::::::::::::::::::::::::::::::::::::: objectifs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the upcoming reviews, the translation of these divs is not required. From guidelines shared:
If there are sections in English, please keep them in English. These tags are needed to render the final website style. The infrastructure that we are using, called Carpentries Workbench, already has them translated.
| # unnest parameters | ||
| unnest_wider(col = epidist_params) %>% | ||
| # to each disease, add sequence from 0.01 to 1 (proportion of transmission) | ||
| expand_grid(percent_transmission = seq(from = 0.01, to = 1, by = 0.01)) %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for @avallecam: sync version with commit at 6c65596
|
|
||
| :::::::::::::::: | ||
|
|
||
| :::::::::::::::: solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for @avallecam: update with latest commit in episode fb67bbe
This is @avallecam speaking:
Dear reviewers, thank you for nominating yourself to review the automatic translation of episodes:
The translated files are accessible in the "Files changed" tab of this PR. Find the Rmd file that corresponds to your assigned episode. Then, click on Load diff.
Find quick links to these that we need with priority:
We are open to accepting your specific changes to one or multiple lines using the "Files changed" tab. To start your review, you can follow steps 5 to 8 from this how-to guide on Reviewing proposed changes in a pull request. Using this method, your line comments are pending and only visible to you. Press Submit Review when finished.
If you prefer an alternative method for review, please let me know, and we can coordinate another platform according to your needs. Each episode could be reviewed on different platforms.
Lastly, we mostly want your review of the French translation of the text only. If you have a thematic or technical improvement you would like the tutorials to have, please feel free to fill an issue. We encourage you to focus on the written content only.