Skip to content

Conversation

@xjules
Copy link
Contributor

@xjules xjules commented Aug 18, 2025

Issue
Further simplification of ParameterConfig API

Approach
move copy_parameters into the LocalEnsemble

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@xjules xjules self-assigned this Aug 18, 2025
@xjules xjules added this to SCOUT Aug 18, 2025
@xjules xjules moved this to Ready for Review in SCOUT Aug 18, 2025
@xjules xjules added the release-notes:skip If there should be no mention of this in release notes label Aug 18, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2025

CodSpeed Performance Report

Merging #11500 will not alter performance

Comparing xjules:copy_params (f1eb32e) with main (8a2a793)

Summary

✅ 22 untouched benchmarks

@dafeda
Copy link
Contributor

dafeda commented Aug 21, 2025

Why is it better to have this function be part of the ensemble and not the experiment?

Edit: I actually quite like this :)

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Aug 21, 2025
@xjules
Copy link
Contributor Author

xjules commented Aug 22, 2025

Nice

Thanks! We will wait with this one a bit since we might remove the group names and use the data files as a grouping of parameters instead.

@xjules xjules moved this from Reviewed to Backlog in SCOUT Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:skip If there should be no mention of this in release notes

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants