Skip to content

Improve compatibility with + add test for DOMException #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve compatibility with + add test for DOMException #3

wants to merge 3 commits into from

Conversation

lionel-rowe
Copy link

Fixes #2

lionel-rowe
lionel-rowe commented Nov 13, 2024
View reviewed changes
ljharb
ljharb reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftr, this polyfill has been tested in every Firefox, Chrome, Edge, Safari, and Opera version Browserstack has listed, so this change will require similar rigor to land.

ljharb
ljharb requested changes Nov 16, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

isError returns false for DOMException instances

2 participants

@lionel-rowe @ljharb