chore: add lint:unused script to run Knip #241
Conversation
|
Oops, it looks like there are quite a few merge conflicts. Whenever you have some time, could you take a look? 😄 |
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
🤔 CI is reporting... ...but I don't see where this would be newly coming from in this PR. Which is up-to-date from |
Co-authored-by: 루밀LuMir <[email protected]>
Co-authored-by: 루밀LuMir <[email protected]>
Co-authored-by: 루밀LuMir <[email protected]>
| "entry": ["tests/**/*.{cts,cts,js,ts}"], | ||
| "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"] |
There was a problem hiding this comment.
| "entry": ["tests/**/*.{cts,cts,js,ts}"], | |
| "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"] | |
| "entry": ["tests/**/*.{cts,js,ts}"], | |
| "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] |
Duplicate extensions
| "entry": ["tests/**/*.{cts,cts,js,ts}"], | ||
| "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"] |
There was a problem hiding this comment.
| "entry": ["tests/**/*.{cts,cts,js,ts}"], | |
| "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"] | |
| "entry": ["tests/**/*.{cts,js,ts}"], | |
| "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] |
|
friendly ping @JoshuaKGoldberg |
have you tried adding |
4 participants
Prerequisites checklist
What is the purpose of this pull request?
Adds Knip to check for unused exports, unused dependencies, and missing dependencies
What changes did you make? (Give an overview)
-yto the jsr launch to explicitly always run it without promptingIs there anything you'd like reviewers to focus on?
Because this repo is a monorepo, its Knip config is a bit more complex than other repos'. I think I got the entry and project properties correct but I'm not positive.