Skip to content

Conversation

@sourcebox
Copy link

This PR is a follow-up to #1 and improves compatibility with Windows and macOS. It is based on stm32-rs#29 from the original repo which uses an alternative approach to set the odd/even flags and also manages incomplete transfers.

Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't claim I really understand all the details here but LGTM

@bjoernQ
Copy link
Collaborator

bjoernQ commented Jul 4, 2024

Thanks! I will give others a chance to have a look before merging this

Copy link

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not super familiar with the driver but LGTM, thanks!

@bjoernQ bjoernQ merged commit cd04629 into esp-rs-compat:esp32sx Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants