-
Notifications
You must be signed in to change notification settings - Fork 112
Task/esp_daylight (IEC-374) #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suda-morris
reviewed
Sep 10, 2025
suda-morris
reviewed
Sep 10, 2025
08800c5
to
a9a49bd
Compare
igrr
reviewed
Sep 11, 2025
igrr
reviewed
Sep 11, 2025
igrr
reviewed
Sep 11, 2025
igrr
reviewed
Sep 11, 2025
igrr
reviewed
Sep 11, 2025
igrr
reviewed
Sep 11, 2025
a9a49bd
to
c9bb8ac
Compare
c9bb8ac
to
c4eb466
Compare
@suda-morris , @igrr , thanks for the review. I have made all the suggested changes and so, marked the conversations as resolved |
igrr
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
url
field definedChange description
This adds a component esp_daylight which can be used to find sunrise/sunset timings at given locations (based on latitude and longitude) using NOAA Solar Calculator. Reference: https://gml.noaa.gov/grad/solcalc/