Skip to content

Conversation

shahpiyushv
Copy link
Contributor

@shahpiyushv shahpiyushv commented Sep 10, 2025

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

This adds a component esp_daylight which can be used to find sunrise/sunset timings at given locations (based on latitude and longitude) using NOAA Solar Calculator. Reference: https://gml.noaa.gov/grad/solcalc/

@github-actions github-actions bot changed the title Task/esp_daylight Task/esp_daylight (IEC-374) Sep 10, 2025
@shahpiyushv shahpiyushv force-pushed the task/esp_daylight branch 2 times, most recently from 08800c5 to a9a49bd Compare September 11, 2025 13:12
@shahpiyushv
Copy link
Contributor Author

@suda-morris , @igrr , thanks for the review. I have made all the suggested changes and so, marked the conversations as resolved

@igrr igrr merged commit 2a04c72 into espressif:master Sep 16, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants