-
Notifications
You must be signed in to change notification settings - Fork 117
[esp_linenoise] Fix small bugs and findings #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[esp_linenoise] Fix small bugs and findings #597
Conversation
d0d63ca to
1a599d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses minor bugs and code quality improvements in the esp_linenoise component, including fixing a macro naming typo, removing an unnecessary self-reference field, and adding getter functions for file descriptors.
- Fixed macro naming from
esp_LINENOISE_CHECK_INSTANCEtoESP_LINENOISE_CHECK_INSTANCE - Removed the
selffield fromesp_linenoise_instance_tstructure and its associated sanity check - Added getter functions
esp_linenoise_get_out_fd()andesp_linenoise_get_in_fd()with test coverage
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| esp_linenoise/src/esp_linenoise.c | Fixed macro naming, removed self-reference assignment, added inline getter functions for file descriptors |
| esp_linenoise/private_include/esp_linenoise_private.h | Removed self field from instance structure and its initialization |
| esp_linenoise/include/esp_linenoise.h | Added documentation for new getter functions |
| esp_linenoise/test_apps/main/test_esp_linenoise_get_set.c | Added test case for new file descriptor getter functions |
| esp_linenoise/idf_component.yml | Version bump from 1.0.0 to 1.0.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The added check for input validation is not really necessary.
1a599d6 to
98b5404
Compare
98b5404 to
579ce6d
Compare
52f3cae to
f58574a
Compare
|
@suda-morris, feel free to merge if the CI is green. |
f58574a to
9a556cf
Compare
Checklist
Change description