Skip to content

Conversation

smartcontracts
Copy link
Contributor

Description
Environment variables should not be directly manipulated in tests because they cause issues when different tests run in parallel that need those env vars to have specific values.

@smartcontracts smartcontracts requested a review from a team as a code owner October 9, 2025 23:36
@smartcontracts smartcontracts requested a review from Inphi October 9, 2025 23:36
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.12%. Comparing base (66e1ddc) to head (f34cd67).
⚠️ Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17813      +/-   ##
===========================================
+ Coverage    74.62%   81.12%   +6.50%     
===========================================
  Files          174      119      -55     
  Lines        11096     6311    -4785     
===========================================
- Hits          8280     5120    -3160     
+ Misses        2672     1191    -1481     
+ Partials       144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 81.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smartcontracts smartcontracts added this pull request to the merge queue Oct 16, 2025
Merged via the queue into develop with commit 515f0c1 Oct 16, 2025
69 checks passed
@smartcontracts smartcontracts deleted the sc/fix-no-env-manip branch October 16, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants