Skip to content

Conversation

bitwiseguy
Copy link
Contributor

@bitwiseguy bitwiseguy commented Oct 10, 2025

Overview

  • Updates the superchain-registry/validation package import so that it includes standard op-contracts/v4.1.0 addresses.
  • Ports support for op-deployer upgrade v4.1.0 from this pr that was made against proposal/op-contracts/v4.1.0
  • Fixes bug in upgrade commands that use contracts tag://
  • Adds CLI level integration tests for upgrade commands

Tests

Uses existing cli runner to invoke upgrade commands via cli interface. Test implementation steps:

  • target standard opcm address based on op-contracts tag
  • fork sepolia at blockNum = (opcmDeploymentBlock) + 1
  • using op-sepolia contract/role addresses, attempt op-deployer upgrade

@bitwiseguy bitwiseguy requested a review from a team as a code owner October 10, 2025 18:34
@bitwiseguy bitwiseguy requested a review from mds1 October 10, 2025 18:34
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.03%. Comparing base (35b7245) to head (249bc5b).
⚠️ Report is 5 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (35b7245) and HEAD (249bc5b). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (35b7245) HEAD (249bc5b)
contracts-bedrock-tests 4 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17824      +/-   ##
===========================================
- Coverage    74.53%   66.03%   -8.50%     
===========================================
  Files          174       55     -119     
  Lines        11076     4785    -6291     
===========================================
- Hits          8256     3160    -5096     
+ Misses        2676     1481    -1195     
  Partials       144      144              
Flag Coverage Δ
cannon-go-tests-64 66.03% <ø> (ø)
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 119 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bitwiseguy bitwiseguy marked this pull request as draft October 10, 2025 19:38
@bitwiseguy bitwiseguy force-pushed the ss/deployer-upgrade-v410 branch from 5aa7723 to 249bc5b Compare October 11, 2025 17:43
@bitwiseguy bitwiseguy marked this pull request as ready for review October 11, 2025 19:01
@bitwiseguy bitwiseguy changed the title op-deployer: support upgrade to v4.1.0 op-deployer: fix, support, test upgrades up to v4.1.0 Oct 11, 2025
@bitwiseguy bitwiseguy added this pull request to the merge queue Oct 13, 2025
Merged via the queue into develop with commit 2ab9b68 Oct 13, 2025
69 checks passed
@bitwiseguy bitwiseguy deleted the ss/deployer-upgrade-v410 branch October 13, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants