Skip to content

Conversation

@mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Oct 20, 2025

Description
This PR updates OPContractsManagerStandardValidator:

Additionally tests are reenabled and updated to handle the DevFeatures.DEPLOY_V2_DISPUTE_GAMES.

This PR builds on:

Tests

Tests have been re-enabled and updated.

Metadata
Closes #17267

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.61%. Comparing base (1f22011) to head (bac987f).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17955      +/-   ##
===========================================
+ Coverage    74.85%   81.61%   +6.76%     
===========================================
  Files          175      120      -55     
  Lines        11261     6494    -4767     
===========================================
- Hits          8429     5300    -3129     
+ Misses        2688     1194    -1494     
+ Partials       144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 81.61% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol 96.13% <100.00%> (ø)
...ock/src/L1/OPContractsManagerStandardValidator.sol 100.00% <100.00%> (+4.60%) ⬆️

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ajsutton ajsutton force-pushed the aj/creator-opcm-addGameType-rebuild branch 2 times, most recently from eabcf5a to 56a3217 Compare October 21, 2025 11:07
@wiz-inc-a178a98b5d
Copy link

wiz-inc-a178a98b5d bot commented Oct 21, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Total -

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@mbaxter mbaxter force-pushed the mbax/issue-17267/update-standard-validator branch from c62c90c to 518ed16 Compare October 21, 2025 16:39
@ajsutton ajsutton force-pushed the aj/creator-opcm-addGameType-rebuild branch from 56a3217 to 761f7e5 Compare October 21, 2025 19:58
Base automatically changed from aj/creator-opcm-addGameType-rebuild to develop October 21, 2025 21:01
@mbaxter mbaxter force-pushed the mbax/issue-17267/update-standard-validator branch from c03bafc to 12bb004 Compare October 21, 2025 21:25
@mbaxter mbaxter marked this pull request as ready for review October 22, 2025 15:20
@mbaxter mbaxter requested a review from a team as a code owner October 22, 2025 15:20
@mbaxter mbaxter requested review from Inphi, ajsutton and alcueca and removed request for alcueca October 22, 2025 15:20
@ajsutton ajsutton force-pushed the mbax/issue-17267/update-standard-validator branch from aa6238a to b72325d Compare October 23, 2025 00:00
@ajsutton ajsutton enabled auto-merge October 23, 2025 00:01
@ajsutton ajsutton added this pull request to the merge queue Oct 23, 2025
Merged via the queue into develop with commit 32d2b05 Oct 23, 2025
70 checks passed
@ajsutton ajsutton deleted the mbax/issue-17267/update-standard-validator branch October 23, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OPCMStandardValidator to handle new dispute game contracts

4 participants