Skip to content

metrics: stop leaking ticker in LogScaled #33072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

metrics: stop leaking ticker in LogScaled #33072

wants to merge 1 commit into from

Conversation

@maradini77
Copy link
Contributor

@maradini77 maradini77 commented Nov 1, 2025

Summary

  • replace time.Tick with a scoped time.NewTicker in LogScaled
  • ensure metric logging releases its timer resources when the loop exits

rjl493456442
rjl493456442 reviewed Nov 1, 2025
View reviewed changes
metrics/log.go
duSuffix := scale.String()[1:]

for range time.Tick(freq) {
ticker := time.NewTicker(freq)
Copy link
Member

@rjl493456442 rjl493456442 Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// The Stop method is no longer necessary to help the garbage collector.
// There is no longer any reason to prefer NewTicker when Tick will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 rjl493456442 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maradini77 @rjl493456442