Skip to content

Fix #459: Suppress "Redundant visibility modifier" Warnings in Generated Code #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #459: Suppress "Redundant visibility modifier" Warnings in Generated Code #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions kotlin-inject-compiler/core/src/main/kotlin/me/tatarka/inject/compiler/InjectGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ class InjectGenerator(
val createFunction = createGenerator.create(astClass, constructor, injectComponent, classOptIn)

return FileSpec.builder(astClass.packageName, injectName).apply {
addAnnotation(createSuppressAnnotation("REDUNDANT_VISIBILITY_MODIFIER"))
astClass.containingFile?.optInAnnotation()?.let { addAnnotation(it) }
createFunction.forEach { addFunction(it) }
addType(injectComponent)
Expand Down Expand Up @@ -425,6 +426,11 @@ fun AstType.toVariableName(): String =
fun AstAnnotated.optInAnnotation(): AnnotationSpec? =
annotation(OPT_IN.packageName, OPT_IN.simpleName)?.toAnnotationSpec()

fun createSuppressAnnotation(reason: String): AnnotationSpec =
AnnotationSpec.builder(Suppress::class)
.addMember("%S", reason)
.build()

private fun AstType.joinArgumentTypeNames(): String = when {
arguments.isEmpty() -> ""
else -> arguments.joinToString(separator = "") {
Expand Down
1 change: 1 addition & 0 deletions ...t-compiler/core/src/main/kotlin/me/tatarka/inject/compiler/KmpComponentCreateGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class KmpComponentCreateGenerator(
packageName = componentClass.packageName,
fileName = "KmpComponentCreate${componentClass.name}",
).apply {
addAnnotation(createSuppressAnnotation("REDUNDANT_VISIBILITY_MODIFIER"))
kmpComponentCreateFunctions.forEach { kmpComponentCreateFunction ->
addFunction(
FunSpec
Expand Down