chore: remove defaults #2629
chore: remove defaults #2629
Conversation
|
The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).
|
| @@ -84,7 +87,7 @@ func InitCmd() *cobra.Command { | |||
|
|
|||
| // Add flags to the command | |||
| rollconf.AddFlags(initCmd) | |||
| initCmd.Flags().String(rollgenesis.ChainIDFlag, "evolve-test", "chain ID") | |||
| initCmd.Flags().String(rollgenesis.ChainIDFlag, "", "chain ID must be set. It is used in the genesis file and to identify the network (examples: ev-1. xo-1)") | |||
There was a problem hiding this comment.
We should make the flag as required or put chain-id as first command argument
block/namespace_test.go
Outdated
| } | ||
|
|
||
| if tt.dataNamespace != "" { | ||
| assert.Equal(t, tt.dataNamespace, dataNS) | ||
| } else if tt.namespace != "" { | ||
| assert.Equal(t, tt.namespace, dataNS) | ||
| } else { | ||
| assert.Equal(t, "rollkit-headers", dataNS) // Falls back to default namespace | ||
| assert.Equal(t, "", dataNS) // Falls back to default namespace |
pkg/cmd/run_node_test.go
Outdated
There was a problem hiding this comment.
No need to add flags here. We can set it in default config above once.
There was a problem hiding this comment.
for some we need the flag as the primary issue is that parseconfig makes a new config and does not use the one provided to the command. the one provided to the command. The test are weird and follow an odd flow but the command is needed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2629 +/- ##
==========================================
- Coverage 69.17% 69.02% -0.16%
==========================================
Files 74 74
Lines 7803 7816 +13
==========================================
- Hits 5398 5395 -3
- Misses 1955 1970 +15
- Partials 450 451 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overview
This pr removes defaults in favor of being explicit for users